-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] #2360
[email protected] #2360
Conversation
Hello @rickeylev, @f0rmiga, modules you maintain (rules_python) have been updated in this PR. Please review the changes. |
Looks like building the wheel for abseil is broken in the example, but that has to do with the something that cmanged in the CI. Could we skip this check and merge as it is? |
We probably can just force submit this, but looping in @fweikert @meteorcloudy to confirm -- do we need to upgrade the C++ toolchain on the macOS VMs or something? |
This is not caused by our recent Mac VM migration, those jobs ran on old Mac fleet. Probably abseil version got upgraded in the new version? Then you'll need
|
rules_python doesn't depend on abseil, though, not directly anyways. Maybe this is coming from something with the proto rules? The failure seems to point to Maybe from this: |
Well, I guess I could add that to our bcr presubmit config, if that fixes it. I don't really like having a different config for BCR vs the actual project, though; it makes last-mile release issues like this more common. I'm a bit confused, though.
The second point seems particularly invasive. Am I missing something? |
I created #2397 to test out the presubmit.yml changes. Even with the |
Ok, it looks if both This still feels like an issue on...idk, the bcr or rules_proto side? But we can just add those to our bcr presubmit config in the meantime. |
I've approved. Can we force-merge this PR? The presubmits from #2397 confirm that the issue is with the presubmit config, and the rules_python code is otherwise fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
@rickeylev Thanks for looking into this! |
Release: https://github.com/bazelbuild/rules_python/releases/tag/0.34.0
Automated by Publish to BCR